Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2173 +/- ##
==========================================
+ Coverage 99.19% 99.21% +0.01%
==========================================
Files 367 378 +11
Lines 14596 14845 +249
==========================================
+ Hits 14479 14728 +249
Misses 117 117 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
CoePaul
force-pushed
the
issue2172
branch
4 times, most recently
from
August 19, 2026 20:26
4cf081e to
13c130e
Compare
* Start with adding JSON validation for system specification JSON dict-like structure expectations * Pydantic BaseModel classes map sub-structures ( sub-dicts ) within the system description structure here adding JSON validation for energy_interval [ the range of x-ray energies (in keV ) over which an absorption curve is valid ] JSON validation for absorption fit curve parameters [ the scaling constant, roll-off vs energy and an optional residuals polynomial ]
CoePaul
changed the title
CoePaul
marked this pull request as ready for review
August 27, 2026 15:17
CoePaul
force-pushed
the
issue2172
branch
3 times, most recently
from
August 27, 2026 23:32
4896111 to
736f148
Compare
* Use pydantic BaseModel classes to capture blobs from Transmission System specification config JSON files for I19 beamlines EH-1 / EH-2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #2172
Instructions to reviewer on how to test:
N.B. Voids in an i19 absorber wedge are bubbles in the absorber material ( 3-D printer output )
and therefore motor positions to avoid:
Nothing to do with the software
voidtype.Checks for reviewer
dodal connect ${BEAMLINE}